add res to all nodes #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kousun12
commented
Jul 17, 2024
| @@ -93,10 +92,10 @@ export class Substrate { | |||
| * @throws {Error} when the client encounters an error making the request. | |||
| */ | |||
| async runSerialized( | |||
| serialized: any, | |||
| nodes: Node[] | null = null, | |||
| nodes: Node[], | |||
There was a problem hiding this comment.
not really sure why this was optional before but seems like it's not used anywhere else, so it seemed okay to change to required
There was a problem hiding this comment.
Yeah, not sure why it can also accept null there either, but that makes sense to me to remove that since we're always passing it through for now
liamgriffiths
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously if you you had a graph where
Bdepends onA, and you didres = substrate.run(B), we would error if you tried to dores.get(A)even though it was in the response.